Adding Metisse to fedora extras

[jim]

Stating this thread because i didn't want to fill up the other thread with info not pertaining to metisse being added to fedora extras.

So to recap

From Post # 149 http://forums.fedoraforum.org/showth...544#post428544

Originally Posted by Finalzone

Fedorajim,

I started to review package, some comments:
- On Release line, add %{?dist} which means a suffix for future version of Fedora i.e. fc4. Read PackageNameGuideline and PackageGuidelines

when I do this it
A fails to build says empty string
A placed a 1 before the %{?dist} and no version was placed in the rpms name

Originally Posted by Finalzone

- spec filename does not have versionning i.e. it should not be metisse04.0.spec. Simply name it metisse.spec.

Done

Originally Posted by Finalzone

- Make sure you have rpmlint or mock installed.

I install rpmlint

here http://fedoraproject.org/wiki/Docs/...ngPackagesGuide
he uses a different method for a release tag

Also, put a "tag" in the release to help show where the package comes from. Then follow it with the actual release in the sequence of packages that you may eventually release.

attached latest spec file used

[Finalzone]

- Add desktop-file-utils on BuildRequires
- Add %{?_smp_mflags} after %{__make}
- Add %find_lang %{name} after %{__install} -D -m 755 %{SOURCE2}
$RPM_BUILD_ROOT/etc/X11/dm/Sessions/metisse.desktop

- On %files line, add -f %{name}.lang
- Add %doc AUTHORS COPYING ChangeLog NEWS README under %defattr(-,root,root,-)


Since nuceo and wm-icons are not available in Extras repository, they should be submitted for review as well.

[jim]

after the changes I am unable to build possible goof up on my part

make[1]: Leaving directory `/home/jim/rpmbuild/BUILD/metisse-0.4.0'
+ rm -rf /var/tmp/metisse-0.4.0-1-root-jim/var/tmp
+ /usr/bin/install -D -m 755 /home/jim/rpmbuild/SOURCES/metisse-session /var/tmp /metisse-0.4.0-1-root-jim/usr/bin/metisse-session
+ /usr/bin/install -D -m 755 /home/jim/rpmbuild/SOURCES/metisse.desktop /var/tmp /metisse-0.4.0-1-root-jim/etc/X11/dm/Sessions/metisse.desktop
+ /usr/lib/rpm/redhat/find-lang.sh /var/tmp/metisse-0.4.0-1-root-jim metisse
No translations found for metisse in /var/tmp/metisse-0.4.0-1-root-jim
error: Bad exit status from /var/tmp/rpm-tmp.93398 (%install)


RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.93398 (%install)
[jim@notebook SPECS]$

From the error

SPEC file

Name : metisse
Version : 0.4.0
Release : 2%{?dist}

License : GPL
Summary : Metisse a 3D X Desktop
Group : User Interface/Desktops

URL : http://insitu.lri.fr/~chapuis/metisse/
Vendor : In Situ research project
Packager : James Lawrence <fedorajim@gmail.com>

Buildroot : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Source0 : %{name}-%{version}.tar.gz
Source1 : metisse-session
Source2 : metisse.desktop

BuildRequires : nucleo >= 0.5, desktop-file-utils
Requires : nucleo >= 0.5, wm-icons >= 0.3.0
AutoReq : no

%description
Metisse is an experimental X desktop with some OpenGL capacity. It
consists of a virtual X server called Xwnc, a special version of FVWM,
and a FVWM module FvwmAmetista. Xwnc is a mix of Xvnc and XDarwin. It
draws nothing on your screen; everything is drawn into
pixmaps. Similarly to Xvnc, but with a different protocol, Xwnc can
send these pixmaps (and other information) to a "viewer". FvwmAmetista
is such a viewer; it uses OpenGL for rendering the X desktop into a
window of a "regular" 3D accelerated X server.

%prep
rm -rf $RPM_BUILD_ROOT

%setup -q

%build
./configure --prefix=/usr --mandir=/usr/share/man
%{__make}
%{?_smp_mflags}

%install
%{__make} DESTDIR=$RPM_BUILD_ROOT prefix=/usr install
rm -rf $RPM_BUILD_ROOT/var/tmp
%{__install} -D -m 755 %{SOURCE1} $RPM_BUILD_ROOT%{_bindir}/metisse-session
%{__install} -D -m 755 %{SOURCE2} $RPM_BUILD_ROOT/etc/X11/dm/Sessions/metisse.desktop
%find_lang %{name}

%clean
rm -rf $RPM_BUILD_ROOT

%files -f %{name}.lang
################################################## ###
# defattr sets the default attributes for all files
################################################## ###
%defattr(-, root, root)
%doc AUTHORS COPYING ChangeLog NEWS README
%{_bindir}/*
%{_datadir}/*
%{_libexecdir}/*
/etc/X11/dm/Sessions/metisse.desktop

%changelog
* Mon Jan 02 2006 James Lawrence <fedorajim@gmail.com> 0.4.0-2.FC4
- modified spec file
* Sat Dec 31 2005 James Lawrence <fedorajim@gmail.com> 0.4.0-1.FC4
- rebuilt for FC4
- Rebuilt with source files 07-12-2005

* Thu Oct 07 2004 Thomas Chung <tchung@fedoranews.org> 0.3.3-2.FC2
- Add metisse-session in /usr/bin/metisse-session
- Add metisse.desktop in /etc/X11/dm/Session/metisse.desktop

* Mon Oct 04 2004 Thomas Chung <tchung@fedoranews.org> 0.3.3-1.FC2
- Clean up spec
- Rebuild for FC2

* Sun Jun 29 2004 Olivier Chapuis <chapuis@lri.fr> 0.3.3-0
- First try at making the package

[jim]

i was able to build again after commenting out

%find_lang %{name} which was under the %install

-f %{name}.lang which was under the %files section

is this going to be a problem?

[Finalzone]

It shoud not be a problem as there is no translation file for metisse.
I forgot to mention that when porting packages to Extras repository, Vendor and Packager lines are not required
since the %changelog already displayed packager name and %doc contain the name of Vendors and developers.
Since Application menu won't contain Metisse shorcut, remove "desktop-file-utils".

Once you fixed these issues, submit these packages for review.

[Finalzone]

Also change the Release line for both wm-icons and nucleo with Release: X%{?dist} where X is the number of release.

[jim]

will upload them in a few then submit them after that its all up to who ever wants to maintain them!

[Finalzone]

If there is no taker, I will maintain metisse and other dependant packages.

[jim]

Bug 177080 Submitted: Review Request: metisse
https://bugzilla.redhat.com/bugzilla....cgi?id=177080

Bug 177081 Submitted: Review Request: nucleo
https://bugzilla.redhat.com/bugzilla....cgi?id=177081

Bug 177082 Submitted: Review Request: wm-icons
https://bugzilla.redhat.com/bugzilla....cgi?id=177082


Here ya are! submitted

[jim]

Nucleo

Needswork:
* Package needs additional BuildRequires. Fails to build in Mock. Refer to
http://fedoraproject.org/wiki/Projects/Mock
* Desirable features need extra BuildRequires: jpeg, png, opengl support, etc.
* Buildroot lacks certain elements. Refer to
http://fedoraproject.org/wiki/Packag...098e1560667de6
* Specified Source URL is not canonical
* License is LGPL, not GPL.
* Some directories need to be owned by this package
* As Luya stated in comment #1, drop the .FC4 fromn the Release tag.
* Drop the Packager, Vendor, and AutoReqProv tags.

NOTE:
This is only an initial look, but there are quite a few items that need to be
corrected, before this can be approved. I would suggest reading all the
packaging information at the wiki, because new contributors need to show
knowledge of the Fedora Extras packaging process before they will be sponsored.
If you have additional questions that the wiki doesn't provide answers to, I
would suggest contacting one of the projects mentors.

http://fedoraproject.org/wiki/Extras
http://fedoraproject.org/wiki/Mentor...310f18002412ce

[Finalzone]

Originally Posted by fedorajim

Nucleo

Needswork:
* Package needs additional BuildRequires. Fails to build in Mock. Refer to
http://fedoraproject.org/wiki/Projects/Mock

mock is very useful because it verifies if the package will succesfully build.
To check about more package that needs to be inc BuildRequires, first install yum-utils.
Then use "yum-builddep </path/specfile>"

* Desirable features need extra BuildRequires: jpeg, png, opengl support, etc.

You need to add devel packages in that line. See above about yum-builddep

* Specified Source URL is not canonical

Source URL started with http://insitu.lri.fr/~chapuis/software/metisse/

Follow the other steps to imporve specs. It is a bit challenging but worth the effort.

[jim]

the yum-builddep
can you provide a example?

[jim@notebook SPECS]$ sudo yum-builddep nucleo.spec
Setting up repositories
Error: No Package Matching nucleo.spec.src

the above is obvious because you wont find nucleo in a repo



FYI i have removed the FC4 from he release line in all of the spec files but when the rpms are built, the rpm name doesn't reflect that thay are built for FC4

[jim]

as for mock just to get a help file it stats you need to be apart of the mock group.
so I added myself to the "mock" group and still get the same thing.

[jim]

Ok solved the mock thing had to log off and back in

ok this is what I get from mock

[jim@notebook ~]$ mock /home/jim/rpmbuild/SRPMS/*.rpm
init
clean
prep

just sits after the prep and ramps up my processor a few times

[Finalzone]

It takes times. mock will let you know if the built was succesful or not. Result is on /var/log/mock/fedora-4/result/.

FYI i have removed the FC4 from he release line in all of the spec files but when the rpms are built, the rpm name doesn't reflect that thay are built for FC4

Don't worry about that. Once you will put these packages in CVS Extras, you will have choice to build on FC4 or devel.