Help Needed with Function Reference Variables (C++)

[Galvin Tjime]

Hello all,

I have recently decided to work on a program to do some calculations for mining in a game and I, in an attempt to make my code more readable, have decided to try and use reference variables for the first time in a function. I am currently coding using Visual C++ 2010 Express (I normally do it in Gedit under Fedora but the person who I am co-writing the code with only uses Windows) and it keeps yelling at me about how there are too many arguments in the function call when I try to input data into the function.

If someone could please help me and tell me what I am doing wrong, I would be most appreciative.

Function:

double set_divisors(double& veld, double& scor, double& pyro, double& plag, double& omber, double& kern, double& jasp)
{
	double divisors[6];

	divisors[0] = veld;
	divisors[1] = scor;
	divisors[2] = pyro;
	divisors[3] = plag;
	divisors[4] = omber;
	divisors[5] = kern;
	divisors[6] = jasp;

	return divisors[6];
}

Function Call:

set_divisors(1000, 833, 844, 256, 307, 386, 269);  //This is where the error occurs

[pforsell]

Your divisors[] array is too small, you declare it to hold 6 double values but you try to use 7 elements, number 0 is the first, number 6 is the seventh.

What is the point of the function? In its current form it only tries to return the 7th element in the array (a single double value). If you wish to return the whole array, either pass a double pointer to some array as an argument to the function, or change the return type to double* and malloc some storage for your newly created array.

The arguments as reference make no sense in this context since you are not modifying them, but this is just a sample code to illustrate the point where the error happens, right?

There are much nicer container types available in C++, may I suggest you look past simple arrays.