PCTel Winmodem Won't Compile (Answered)

[meff]

So, I got the latest PCTel drivers that have worked on every 2.4.* kernel I've used so far, including 22 .. So I figured i'd have no problem with Fedora... ERR! .. *sigh*

[code:1]
gcc32 -D__KERNEL__ -Werror -Wno-trigraphs -fno-common -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -fno-strength-reduce -DMODULE -DMODVERSIONS -DEXPORT_SYMTAB -DHAL_PCT789 -DBUILD_SYSTEM=""`uname -s -m -r -p`"" -DGCC_VERSION=""`gcc --version | head -1`"" -I../../include -I/usr/src/linux/include -include /usr/src/linux/include/linux/modversions.h -DPACKAGE_NAME="" -DPACKAGE_TARNAME="" -DPACKAGE_VERSION="" -DPACKAGE_STRING="" -DPACKAGE_BUGREPORT="" -DPACKAGE="pctel" -DVERSION="0.9.5" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -c -o ptserial.o ptserial.c
ptserial.c: In function `rs_close':
ptserial.c:2813: invalid operands to binary ==
make[3]: *** [ptserial.o] Error 1
make[3]: Leaving directory `/usr/src/hardware/pctel_winmodem/pctel-0.9.6/src/ptserial'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/usr/src/hardware/pctel_winmodem/pctel-0.9.6/src/ptserial'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/src/hardware/pctel_winmodem/pctel-0.9.6/src'
make: *** [all-recursive] Error 1
[/code:1]

Kaboom. Anyone have any idea?

Here's what I used to ./configure :

[code:1]
./configure --with-hal=pct789 CC=gcc32
[/code:1]

If anyone can help, speak up. Thanks :)

[Avatraxiom]

So this is the exact same version of the drivers that successfully compiled on your 2.4.20-20.9 Red Hat 9 machine?

What is that line of code that it crashes on? (That is, find it in the source and paste it in.)

-M

[meff]

Well, I've never used RH before Fedora, but this worked fine on vanilla 22 and most any other kernel I've tried it on..

Here's the code on that line, and a few lines after:

[code:1]
if ((tty->count == 1) && (state->count != 1)) {
printk("rs_close: bad serial port count; tty->count is 1, " "state->count is %dn", state->count);
state->count = 1;
}
[/code:1]

[Avatraxiom]

My assumption here is that one of the Red Hat kernel patches changed the type of one of those variables. You should probably ask the driver developers of this driver that you're compiling if they have a Red Hat / Fedora version, or if they know what patch it is that's causing this trouble.

-M

[meff]

My assumption here is that one of the Red Hat kernel patches changed the type of one of those variables. You should probably ask the driver developers of this driver that you're compiling if they have a Red Hat / Fedora version, or if they know what patch it is that's causing this trouble.

Well crap. It's more or less un-maintained at the moment.. And the only thing that works for my winmodem, and I am currently out of cash to get a real one.. *shrug*

Any idea on what to do?

[Avatraxiom]

Any idea on what to do?

I have some ideas.

(1) Which of those lines is 2813? You could ask (a) the fedora-devel-list and (b) the Linux Kernel Mailing List (As a last resort) why you would get that error. Or, first, you could try and ask #fedora-devel why that error would show up, and paste them that line of code. mkj would be the best person to ask, probably, but others might know. You'd probably want to ask during work hours PST, or just slightly after. (Just slightly after tends to work pretty well, for me, since people get home and glace at IRC.)

(2) Those lines look like a sanity check for the driver. If you feel like being risky, you could delete that entire "if" block from the code. (That is, everything you pasted there, you could just rip out.) I'm not sure that would make everything compile, but it might be a start.

-M

[meff]

Followup:

Someone has patched it and is re-releasing the pctel driver with Fedora compatable code:
http://hepunx.rl.ac.uk/~wmurray/pctel/pctel.html

Good luck, if anyone else has this modem...